Messages in this thread | | | Date | Mon, 30 Sep 2013 12:01:25 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] regulator: ti-abb: Remove redundant of_match_ptr |
| |
On Mon, Sep 30, 2013 at 02:27:13PM +0530, Sachin Kamat wrote: > The data structure of_match_ptr() protects is always compiled in. > Hence of_match_ptr() is not needed.
It seems like good practice to include these even if they're not currently doing anything - for example, if ACPI support were added to the driver then you could get an ACPI kernel OF disabled.
Note that one of the things these macros are supposed to do (but don't yet IIRC) is allow for dead code elimination to discard references to things automatically even without the being ifdefed out. [unhandled content-type:application/pgp-signature] | |