Messages in this thread | | | Date | Tue, 3 Sep 2013 19:18:42 -0700 | Subject | Re: [PATCH 1/3] autofs4 - fix device ioctl mount lookup | From | Linus Torvalds <> |
| |
On Tue, Sep 3, 2013 at 7:00 PM, Al Viro <viro@zeniv.linux.org.uk> wrote: > > That aside, I'm really not happy with this kind of games; this stuff clearly > belongs in fs/namei.c where we can simply see the last component. Doing that > on the level of "let's scan the pathname for slashes, etc." is just plain > wrong. Let's step back for a minute here; what are you trying to do? > You have a pathname that should resolve to a mountpoint, without triggering > automount (or crossing into the mountpoint, for that matter) and you want > struct path for the bottom of that mount stack? Or is it something > completely different?
Can we add a LOOKUP_NOAUTOMNT bit or something (not exposed to user space, only used for this particular kern_path() call). Then, if/when automount gets called recursively (through autofs4_lookup? Or is it just the autofs4_d_automount() interface?) it can just decide to not follow that last path.
Hmm? I don't think we pass in the lookup-flags to d_automount, but that could be changed. Yes?
Linus
| |