Messages in this thread | | | Date | Tue, 3 Sep 2013 18:27:49 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH-v5 1/6] idr: Percpu ida |
| |
On Tue, 03 Sep 2013 09:06:58 -0700 "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote:
> Are there any other review comments to be addressed for this patch..? > > If not, please kindly give your Reviewed-by if your OK for an initial > standalone merge.
Sorry, I'm largely offline for the next week...
It looks OK to me (that's as close as I get to an ack :))
Nit:
> + if (cpu >= nr_cpu_ids) > + cpu = cpumask_first(&pool->cpus_have_tags); > + > + if (cpu >= nr_cpu_ids) > + BUG();
The second `if' can be moved inside the first, but hopefully the compiler already did that.
I have dim memories that doing
local_irq_save() spin_lock()
is not equivalent to
spin_lock_irqsave()
in some circumstances. Perhaps a lockdep thing. Or perhaps this was fixed in the intervening years and this is no longer the case.
Such things probably won't be detected during 3.12-rcX because few people will test iscsi, I expect. So please be sure that you've runtime tested it with all the lockdeppy things enabled. Documentation/SubmitChecklist section 12 has a list, but it might be dated.
| |