Messages in this thread | | | Date | Tue, 3 Sep 2013 14:40:09 -0700 | From | Greg KH <> | Subject | Re: usb: host: Faraday fotg210-hcd driver |
| |
On Tue, Sep 03, 2013 at 05:32:05PM -0400, Dave Jones wrote: > On Tue, Sep 03, 2013 at 02:23:55PM -0700, Greg KH wrote: > > > > > +config USB_FOTG210_HCD > > > > + tristate "FOTG210 HCD support" > > > > + depends on USB > > > > + default N > > > > + ---help--- > > > > + Faraday FOTG210 is an OTG controller which can be configured as > > > > + an USB2.0 host. It is designed to meet USB2.0 EHCI specification > > > > + with minor modification. > > > > + > > > > + To compile this driver as a module, choose M here: the > > > > + module will be called fotg210-hcd. > > > > + > > > > > > Shouldn't this depend on USB_OTG ? > > > Seems odd to have OTG related options presented to me when I have that unset. > > > > It's a USB Host controller, so it should be built if you have that > > option set. The fact that it can do OTG isn't an issue here, from what > > I can tell. > > Ok. It still likely needs a 'depends on $ARCH (arm?) | COMPILE_TEST' though.
Probably, yes.
> PS: What happened with this driver ? > > This patch landed twice in your tree, once in 1dd3d123239179fad5de5dc00a6e0014a1918fde from Yuan-Hsin Chen <yhchen@faraday-tech.com> > and then in 7d50195f6c5005d6ae7a789d9a7f0a94d104ee96 from Feng-Hsin Chiang <john453@faraday-tech.com> > > Given the former address seems to be broken, perhaps all those mentions of it > in the faraday sources need updating ?
I thought they had all been fixed up. The first version was dropped because the maintainer no longer worked for the company (as you found out), so I needed a new developer to step up and support it.
thanks,
greg k-h
| |