lkml.org 
[lkml]   [2013]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] mfd: arizona: Update device tree regulator bindings
On Sun, Sep 29, 2013 at 06:52:36PM +0100, Mark Brown wrote:
> On Sun, Sep 29, 2013 at 03:11:37PM +0100, Charles Keepax wrote:
>
> > There is currently only one other MFD driver (tps65910) which defines
> > the GPIOs on the main MFD node as we do in the Arizona driver and it
> > uses the 'hack' that I suggested in my first email of copying the
> > of_node.
>
> > tps65910_gpio->gpio_chip.of_node = tps65910->dev->of_node;
>
> Look where it's copying it to - this isn't the hack you were suggesting
> before. What you were suggesting before was setting the of_node of the
> child struct device which is a managed thing that the driver core knows
> about, the device is the owner of the of_node hanging off it. You would
> end up with the same of_node referenced from two struct devices which
> isn't clever. The above is putting a pointer into the gpio_chip which
> is just telling gpiolib that it should use this of_node when it needs
> one, gpiolib won't try and lifecycle manage the of_node.

Ah, of course, I see now.


Thanks,
Charles



\
 
 \ /
  Last update: 2013-09-29 20:41    [W:0.056 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site