Messages in this thread | | | Date | Sun, 29 Sep 2013 13:30:19 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/3] spi: Add a spi_w8r16be() helper |
| |
On Fri, Sep 27, 2013 at 10:01:36PM +0200, Lars-Peter Clausen wrote: > On 09/27/2013 09:22 PM, Mark Brown wrote:
> > Indeed. I don't think that's terribly well thought through though, > > especially not now we have annotations for endianness (as you noticed!).
> I wouldn't mind updating spi_w8r16() to do the conversion to big-endian. > Especially considering that a driver using the function will probably always > need to do a endian conversion anyway to work correctly on both > endiannesses. We can add a LE variant if we should ever need it.
I think that's probably the way to go, the API seems to error prone as it is. [unhandled content-type:application/pgp-signature] | |