lkml.org 
[lkml]   [2013]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [pchecks v2 2/2] percpu: Add preemption checks to __this_cpu ops

* Christoph Lameter <cl@linux.com> wrote:

> > The blind __this_cpu conversions without proper preempt debugging
> > cannot continue without first fixing all the fallout of the missing
> > debug checks to begin with.
>
> That will take some time as the feedback from the other patchset
> suggests.

That's the reason why we insisted on __this_cpu*() primitives growing
these essential debug checks early on - which you resisted. I had to bring
out NAKs for you to see sense and start fixing the mess already - next
time around I'll probably have to NAK your changes earlier to prevent such
mishaps.

( Note that some false positives were possibly fixed by the use of the
lib/smp_processor_id.c methods to check for preemptability, so the
situation might not be as dire as your first series suggests. )

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-09-28 11:01    [W:0.085 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site