Messages in this thread | | | Date | Sat, 28 Sep 2013 10:44:12 +0200 | From | Ingo Molnar <> | Subject | Re: [pchecks v2 2/2] percpu: Add preemption checks to __this_cpu ops |
| |
* Christoph Lameter <cl@linux.com> wrote:
> > The blind __this_cpu conversions without proper preempt debugging > > cannot continue without first fixing all the fallout of the missing > > debug checks to begin with. > > That will take some time as the feedback from the other patchset > suggests.
That's the reason why we insisted on __this_cpu*() primitives growing these essential debug checks early on - which you resisted. I had to bring out NAKs for you to see sense and start fixing the mess already - next time around I'll probably have to NAK your changes earlier to prevent such mishaps.
( Note that some false positives were possibly fixed by the use of the lib/smp_processor_id.c methods to check for preemptability, so the situation might not be as dire as your first series suggests. )
Thanks,
Ingo
| |