Messages in this thread | | | Subject | Re: [PATCH v6 5/6] MCS Lock: Restructure the MCS lock defines and locking code into its own file | From | Joe Perches <> | Date | Fri, 27 Sep 2013 06:44:55 -0700 |
| |
On Fri, 2013-09-27 at 13:23 +0200, Peter Zijlstra wrote: > checkpatch.pl should really warn about that; and it appears there > code in there for that; however: > > # grep -C3 smp_mb scripts/checkpatch.pl [] > # check for memory barriers without a comment. > if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) { > if (!ctx_has_comment($first_line, $linenr)) { > CHK("MEMORY_BARRIER", > "memory barrier without comment\n" . $herecurr); [] > # scripts/checkpatch.pl -f kernel/mutex.c 2>&1 | grep memory > # > > so that appears to be completely broken :/ > > Joe, any clue what's up with that?
It's a CHK test, so it's only tested with --strict
$ scripts/checkpatch.pl -f --strict kernel/mutex.c 2>&1 | grep memory CHECK: memory barrier without comment CHECK: memory barrier without comment
It could be changed to WARN so it's always on.
| |