Messages in this thread | | | Date | Thu, 26 Sep 2013 23:05:06 +0300 (EEST) | From | Julian Anastasov <> | Subject | Re: [PATCH] ipvs: improved SH fallback strategy |
| |
Hello,
On Thu, 26 Sep 2013, Alexander Frolkin wrote:
> Improve the SH fallback realserver selection strategy. > > With sh and sh-fallback, if a realserver is down, this attempts to > distribute the traffic that would have gone to that server evenly > among the remaining servers. > > Signed-off-by: Alexander Frolkin <avf@eldamar.org.uk>
Looks correct to me, just fix the below indentations. Also, please use version number for your patches, eg. [PATCHv2] ipvs: ...
> diff --git a/net/netfilter/ipvs/ip_vs_sh.c b/net/netfilter/ipvs/ip_vs_sh.c > index 3588fae..533ea53 100644 > --- a/net/netfilter/ipvs/ip_vs_sh.c > +++ b/net/netfilter/ipvs/ip_vs_sh.c
> + IP_VS_DBG_BUF(6, "SH: selected unavailable server " > + "%s:%d, reselecting", > + IP_VS_DBG_ADDR(svc->af, &dest->addr), > + ntohs(dest->port));
Indentation:
IP_VS_DBG_BUF(6, "SH: selected unavailable server %s:%d, reselecting", IP_VS_DBG_ADDR(svc->af, &dest->addr), ntohs(dest->port));
> + IP_VS_DBG_BUF(6, "SH: selected unavailable " > + "server %s:%d (offset %d), reselecting", > + IP_VS_DBG_ADDR(svc->af, &dest->addr), > + ntohs(dest->port), > + roffset);
Indentation:
IP_VS_DBG_BUF(6, "SH: selected unavailable " "server %s:%d (offset %d), reselecting", IP_VS_DBG_ADDR(svc->af, &dest->addr), ntohs(dest->port), roffset);
Regards
-- Julian Anastasov <ja@ssi.bg>
| |