Messages in this thread | | | Date | Thu, 26 Sep 2013 09:38:27 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH 1/2] pinctrl: palmas: do not abort pin configuration for BIAS_DEFAULT |
| |
On 09/26/2013 06:48 AM, Laxman Dewangan wrote: > Recent movement of all configurations of pin in the single call of > pin_config_set(), it is aborting configuration if BIAS_PULL_PIN_DEFAULT > is selected as return of configuration. > > The original idea was to just avoid any update on register for pull up/down > configuration if this option is selected.
That doesn't sound correct. If a config option is specified in DT or the mapping table, it should be applied to HW. If someone doesn't want a particular config option applied, then it simply shouldn't be mentioned in DT or the mapping table.
IIUC, BIAS_DEFAULT should be used only on HW where there is a concept of a true default bias, and in that case, that is what should be applied.
| |