lkml.org 
[lkml]   [2013]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/11] sched, rcu: Make RCU use resched_cpu()
On Mon, Sep 23, 2013 at 02:18:27PM -0700, Paul E. McKenney wrote:
> Passes light testing, but I am confused about why the change to
> resched_task() when only resched_cpu() is invoked elsewhere in the patch.
> Enlightenment?
> > > -#ifdef CONFIG_SMP
> > > void resched_task(struct task_struct *p)
> > > {
> > > int cpu;
> > >
> > > - assert_raw_spin_locked(&task_rq(p)->lock);
> > > + lockdep_assert_held(&task_rq(p)->lock);
> > >
> > > if (test_tsk_need_resched(p))
> > > return;

That one? Fly by fixup I suppose.. the lockdep check is cheaper as it
compiles away for !lockdep kernels, also its more correct.


\
 
 \ /
  Last update: 2013-09-24 10:21    [W:0.066 / U:3.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site