lkml.org 
[lkml]   [2013]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] apparmor: remove the "task" arg from may_change_ptraced_domain()
On 09/23, Richard Guy Briggs wrote:
>
> On Mon, Sep 16, 2013 at 04:20:35PM +0200, Oleg Nesterov wrote:
> > Unless task == current ptrace_parent(task) is not safe even under
> > rcu_read_lock() and most of the current users are not right.
>
> Could you point to an explanation of this?

If this task exits before rcu_read_lock() ->parent can point to the
already freed/reused memory.

(in the long term we should probably clear
->parent/real_parent/group_leader/more in __unhash_process(), but
lets not discuss this right now ;)

> (Did you send a patch to fix the selinux hook?)

No, sorry, I was sick. Will do.

> Acked-by: Richard Guy Briggs <rgb@redhat.com>

Thanks!

Oleg.



\
 
 \ /
  Last update: 2013-09-24 19:21    [W:0.068 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site