Messages in this thread | | | Date | Tue, 24 Sep 2013 18:38:11 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v3] kthread: Make kthread_create() killable. |
| |
On 09/25, Tetsuo Handa wrote: > > Subject: [PATCH] kthread: make kthread_create() killable
The patch looks correct... although I'll try to reread it later ;)
Minor nit, since you are sending the new version anyway...
> + if (unlikely(wait_for_completion_killable(&done))) { > + /* > + * If I was SIGKILLed before kthreadd (or new kernel thread) > + * calls complete(), leave the cleanup of this structure to > + * that thread. > + */ > + if (xchg(&create->done, NULL)) > + return ERR_PTR(-ENOMEM);
ENOMEM? Perhaps EINTR makes more sense.
Oleg.
| |