Messages in this thread | | | Date | Tue, 24 Sep 2013 06:39:49 -0600 | From | Shuah Khan <> | Subject | Re: [PATCH 1/2] iommu: Add iommu_fault class event to iommu trace |
| |
On 09/24/2013 04:48 AM, Joerg Roedel wrote: > On Fri, Aug 16, 2013 at 11:20:16AM -0600, Shuah Khan wrote: >> +DEFINE_EVENT(iommu_fault, report_fault, >> + >> + TP_PROTO(struct device *dev, unsigned long iova, int flags), >> + >> + TP_ARGS(dev, iova, flags) >> +); > > I am not entirely happy with the naming. It is better to name the class > iommu_error and the page-fault event io_page_fault. This makes it more > clear what kind of fault it is. > > > Joerg > >
Joerg,
Yes, iommu_error and io_page_fault sounds better. I will rename and send the updated patch.
-- Shuah
-- Shuah Khan Senior Linux Kernel Developer - Open Source Group Samsung Research America(Silicon Valley) shuah.kh@samsung.com | (970) 672-0658
| |