lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pinctrl: pinctrl-adi2: Remove nested lock+irqsave that resue flags.
On Mon, Sep 23, 2013 at 05:29:48PM +0800, Sonic Zhang wrote:
> @@ -323,12 +323,12 @@ static unsigned int adi_gpio_irq_startup(struct irq_data *d)
> struct gpio_pint_regs *regs = port->pint->regs;
^^^^^^^^^^^^^^^^
Dereference.

>
> if (!port) {
^^^^^
Too late to check here.

> - dev_err(port->dev, "GPIO IRQ %d :Not exist\n", d->irq);
> + pr_err("GPIO IRQ %d :Not exist\n", d->irq);
> return -ENODEV;
> }

regards,
dan carpenter
>


\
 
 \ /
  Last update: 2013-09-23 15:01    [W:0.084 / U:2.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site