Messages in this thread | | | Date | Sat, 21 Sep 2013 17:59:15 +0200 | From | Leif Lindholm <> | Subject | Re: [PATCH 02/11] efi: Remove EFI_PAGE_SHIFT and EFI_PAGE_SIZE |
| |
On Sat, Sep 21, 2013 at 05:41:43PM +0200, Borislav Petkov wrote: > On Sat, Sep 21, 2013 at 05:21:39PM +0200, Leif Lindholm wrote: > > > It will probably not be a problem on the stub side, and it's not used > > in many places but it would break efi_lookup_mapped_address(), > > efi_range_is_wc() and memrange_efi_to_native() for use by arm64. > > At least the first of these would be a problem. > > Ok, maybe the generic header include/linux/efi.h might be a problem but > the rest are changes to arch/x86/ which should have no effect whatsoever > on any other arch.
Indeed - my concerns are restricted to include/linux/efi.h and drivers/firmware/efi.c.
> Or are you planning to move some of it into generic code?
I think some of the stub code is moved to generic in Roy's/Mark's patches - but then the stub shouldn't be an issue as in UEFI we have 4K pages.
/ Leif
| |