Messages in this thread | | | Date | Sat, 21 Sep 2013 15:32:55 +0100 | From | Al Viro <> | Subject | Re: tracing: don't stuff stale pointers in filp->private_data |
| |
On Fri, Sep 20, 2013 at 12:47:32PM -0400, Dave Jones wrote: > Probably harmless, but still not a nice thing to do. > > Signed-off-by: Dave Jones <davej@fedoraproject.org> > > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index 368a4d5..75d3556 100644 > --- a/kernel/trace/trace_events.c > +++ b/kernel/trace/trace_events.c > @@ -1124,6 +1124,7 @@ static int system_tr_open(struct inode *inode, struct file *filp) > if (ret < 0) { > trace_array_put(tr); > kfree(dir); > + dir = NULL; > } > > filp->private_data = dir;
Er... Why not simply return ret; instead?
| |