Messages in this thread Patch in this message | | | From | Peter Senna Tschudin <> | Subject | [PATCH 19/19] net: Change variable type to bool | Date | Sun, 22 Sep 2013 00:27:51 +0200 |
| |
The variable fully_acked is only assigned the values true and false. Change its type to bool.
The simplified semantic patch that find this problem is as follows (http://coccinelle.lip6.fr/):
@exists@ type T; identifier b; @@ - T + bool b = ...; ... when any b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> --- net/ipv4/tcp_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 25a89ea..fa17dce 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -2970,7 +2970,7 @@ static int tcp_clean_rtx_queue(struct sock *sk, int prior_fackets, const struct inet_connection_sock *icsk = inet_csk(sk); struct sk_buff *skb; u32 now = tcp_time_stamp; - int fully_acked = true; + bool fully_acked = true; int flag = 0; u32 pkts_acked = 0; u32 reord = tp->packets_out; -- 1.8.3.1
| |