Messages in this thread | | | Date | Thu, 19 Sep 2013 11:04:34 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 2/3] mfd: mc13xxx: Move SPI erratum workaround into SPI I/O function |
| |
> Please delete irrelevant context from mails, it makes it easier to find > the new content that's beenn added.
I did, off the bottom.
I only left 22 lines at the top. You're just being pernickety.
> > On Wed, 18 Sep 2013, Mark Brown wrote: > > > > @@ -94,10 +94,15 @@ static int mc13xxx_spi_write(void *context, const void *data, size_t count) > > > { > > > struct device *dev = context; > > > struct spi_device *spi = to_spi_device(dev); > > > + char *reg = data; > > > I think this requires a cast. > > No, you should never need a cast to or from void in C - it probably does > want to be a const char though.
Either way, it needs changing.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |