lkml.org 
[lkml]   [2013]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] pwm: atmel-tcb: add missing clk source config
    On 18/09/2013 17:06, Boris BREZILLON :
    > Clock source changes are never applied to the CMR register.
    > This may lead to wrong period/duty cycle configuration.
    >
    > Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>

    Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

    > ---
    > drivers/pwm/pwm-atmel-tcb.c | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
    > index ba6ce01..0266969 100644
    > --- a/drivers/pwm/pwm-atmel-tcb.c
    > +++ b/drivers/pwm/pwm-atmel-tcb.c
    > @@ -249,6 +249,8 @@ static int atmel_tcb_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
    > }
    > }
    >
    > + cmr |= (tcbpwm->div & ATMEL_TC_TCCLKS);
    > +
    > __raw_writel(cmr, regs + ATMEL_TC_REG(group, CMR));
    >
    > if (index == 0)
    >


    --
    Nicolas Ferre


    \
     
     \ /
      Last update: 2013-09-19 09:41    [W:2.865 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site