Messages in this thread | | | Date | Wed, 18 Sep 2013 10:54:20 +0530 | From | Anshuman Khandual <> | Subject | Re: [PATCH 1/8][v4] powerpc/perf: Rename Power8 macros to start with PME |
| |
On 09/14/2013 06:19 AM, Sukadev Bhattiprolu wrote: > We use helpers like GENERIC_EVENT_ATTR() to list the generic events in > sysfs. To avoid name collisions, GENERIC_EVENT_ATTR() requires the perf > event macros to start with PME.
We got all the raw event codes covered for P7 with the help of power7-events-list.h enumeration.
/* * Power7 event codes. */ #define EVENT(_name, _code) \ PME_##_name = _code,
enum { #include "power7-events-list.h" }; #undef EVENT
Just wondering if its a good idea to name change these selected macros to be consumed by GENERIC_EVENT_ATTR() right here for this purpose or we need to get the comprehensive list of raw events for P8 first. Just an idea.
Regards Anshuman
| |