lkml.org 
[lkml]   [2013]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [11/51] Input: atmel_mxt_ts - Implement CRC check for configuration data
    On 27/06/13 14:48, Nick Dyer wrote:
    > The configuration is stored in NVRAM on the maXTouch chip. When the device is
    > reset it reports a CRC of the stored configuration values. Therefore it isn't
    > necessary to send the configuration on each probe - we can check the CRC
    > matches and avoid a timeconsuming backup/reset cycle.
    >
    > Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk>
    > Acked-by: Benson Leung <bleung@chromium.org>
    > -static unsigned mxt_extract_T6_csum(const u8 *csum)
    > +static u16 mxt_extract_T6_csum(const u8 *csum)
    > {
    > return csum[0] | (csum[1] << 8) | (csum[2] << 16);
    > }

    Shouldn't this be u32?
    It's losing data causing the checksums not to match for me.



    \
     
     \ /
      Last update: 2013-09-18 19:41    [W:8.597 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site