Messages in this thread Patch in this message | | | Date | Wed, 18 Sep 2013 17:42:24 +0200 | From | Peter Zijlstra <> | Subject | Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page' |
| |
On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: > Can you point to any code that is fixed by the commit?
I have some, but I don't think a lot of people use it.
Would you be ok with something like the below? It should preserve functionality for code that only cares about cap_usr_rdpmc (PAPI).
Stephane, does libpfm use any of these?
--- a/include/uapi/linux/perf_event.h +++ b/include/uapi/linux/perf_event.h @@ -380,8 +380,8 @@ struct perf_event_mmap_page { union { __u64 capabilities; struct { - __u64 cap_usr_time : 1, - cap_usr_rdpmc : 1, + __u64 cap_usr_rdpmc : 1, + cap_usr_time : 1, cap_usr_time_zero : 1, cap_____res : 61; };
| |