Messages in this thread Patch in this message | | | Subject | Re: [PATCH 01/28] c6x: use boot_command_line instead of private c6x_command_line | From | Mark Salter <> | Date | Wed, 18 Sep 2013 09:35:32 -0400 |
| |
On Mon, 2013-09-16 at 18:08 -0500, Rob Herring wrote: > From: Rob Herring <rob.herring@calxeda.com> > > Save some pointless copying of the kernel command line and just use > boot_command_line instead. > > Also remove default_command_line as it is not referenced anywhere, and > the DT code already handles the default command line. >
The default_command_line is leftover cruft from the kernel before it was upstreamed. It was a mechanism to place the commandline at a known fixed offset in the Image. It was needed for simple (serial eeprom based) loaders which didn't know about DT. Anyway, bits of that support are missing, so I don't see a reason to keep it around. If anyone complains we can add it back in as a completely functional patch. There is also a fragment of arch/c6x/kernel/vmlinux.lds.S which should also be removed:
diff --git a/arch/c6x/kernel/vmlinux.lds.S b/arch/c6x/kernel/vmlinux.lds.S index 279d807..5a6e141 100644 --- a/arch/c6x/kernel/vmlinux.lds.S +++ b/arch/c6x/kernel/vmlinux.lds.S @@ -37,12 +37,6 @@ SECTIONS _vectors_end = .; } - . = ALIGN(0x1000); - .cmdline : - { - *(.cmdline) - } - /* * This section contains data which may be shared with other * cores. It needs to be a fixed offset from PAGE_OFFSET
| |