Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 1/5] scripts: Add mkstrerror.sh | Date | Wed, 18 Sep 2013 12:55:10 +0100 |
| |
David Howells <dhowells@redhat.com> wrote:
> (1) Why are you double-NUL'ing all your strings? (see the \0 in the strings)
Ah... I see what you're doing. I missed the fact that you don't have a comma after each string.
> (3) You are storing a pointer to the symbolic name for each error. On a > 64-bit machine, that's 8 bytes. If you drop the leading 'E' and the > trailing NUL, most symbols will fit into an 8 character slot saving you > the cost of a pointer. > ...
In which case, you can ignore this too.
David
| |