lkml.org 
[lkml]   [2013]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/5] scripts: Add mkstrerror.sh
Date
David Howells <dhowells@redhat.com> wrote:

> (1) Why are you double-NUL'ing all your strings? (see the \0 in the strings)

Ah... I see what you're doing. I missed the fact that you don't have a comma
after each string.

> (3) You are storing a pointer to the symbolic name for each error. On a
> 64-bit machine, that's 8 bytes. If you drop the leading 'E' and the
> trailing NUL, most symbols will fit into an 8 character slot saving you
> the cost of a pointer.
> ...

In which case, you can ignore this too.

David


\
 
 \ /
  Last update: 2013-09-18 14:01    [W:0.085 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site