Messages in this thread | | | Date | Wed, 18 Sep 2013 01:19:33 +0200 | From | Paolo Bonzini <> | Subject | Re: [PATCH 1/3] KVM: cleanup (physical) CPU hotplug |
| |
Il 17/09/2013 09:57, Jan Kiszka ha scritto: >> > Remove the useless argument, and do not do anything if there are no >> > VMs running at the time of the hotplug. > kvm_cpu_hotplug already filters !kvm_usage_count. If we need the check > to be under kvm_lock, drop that line as well. If that is not required > (machine still halted?), drop the related changes here.
CPU_DYING is called under stop_machine, CPU_STARTING is not. So I should drop the test in kvm_cpu_hotplug. It's a bit clearer anyway to not rely on stop_machine.
Paolo
| |