lkml.org 
[lkml]   [2013]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] input: Return the number of bytes written so far on evdev write failure
    Date
    If input_event_from_user() fails in evdev write() and at least one
    event has been written successfully then return the number of bytes
    written. If no events have been written, then the EFAULT error is
    returned.

    Signed-off-by: Ryan Mallon <rmallon@gmail.com>
    ---
    drivers/input/evdev.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
    index d2b34fb..b0dec2ba 100644
    --- a/drivers/input/evdev.c
    +++ b/drivers/input/evdev.c
    @@ -437,7 +437,8 @@ static ssize_t evdev_write(struct file *file, const char __user *buffer,
    while (retval + input_event_size() <= count) {

    if (input_event_from_user(buffer + retval, &event)) {
    - retval = -EFAULT;
    + if (retval == 0)
    + retval = -EFAULT;
    goto out;
    }
    retval += input_event_size();
    --
    1.7.9.7


    \
     
     \ /
      Last update: 2013-09-18 01:01    [W:3.474 / U:0.424 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site