lkml.org 
[lkml]   [2013]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/11] 9p: fix dentry leak in v9fs_vfs_atomic_open_dotl()
From
On Tue, Sep 17, 2013 at 1:44 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Tue, Sep 17, 2013 at 12:16:56PM +0200, Miklos Szeredi wrote:
>
>> Just one. This needs to be removed, since this condition is now
>> explicitly allowed and later checked for:
>>
>> if (WARN_ON(excl && !(*opened & FILE_CREATED)))
>> *opened |= FILE_CREATED;
>
> D'oh... Fixed and pushed.

Okay, but moving the fsnotify_create() to after the no-open section
is wrong, I think, It's needed for the case of ->atomic_open() doing
lookup/create/no_open too.

Thanks,
Miklos


\
 
 \ /
  Last update: 2013-09-17 18:01    [W:0.185 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site