lkml.org 
[lkml]   [2013]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/4] pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface
    From
    On Mon, Sep 9, 2013 at 6:03 PM, Guennadi Liakhovetski
    <g.liakhovetski@gmx.de> wrote:

    > There are four I2C interfaces on r8a7790, each of them can be connected to
    > one of the two respective I2C controllers, e.g. interface #0 can be
    > configured to work with I2C0 or with IIC0. Additionally some of those
    > interfaces can also use one of several pin sets. Interface #3 is special,
    > because it can be used in automatic mode for DVFS. It only has one set
    > of pins available and those pins cannot be used for anything else, they
    > also lack the GPIO function.
    >
    > This patch uses the sh-pfc ability to configure pins, not associated with
    > GPIOs and adds support for I2C3 to the r8a7790 PFC set up.
    >
    > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>

    Pls CC Laurent who is main reviewer on all sh-pfc stuff.

    > +/* R8A7790 has 6 banks with 32 GPIOs in each = 192 GPIOs */
    > +#define ROW_GROUP_A(r) ('Z' - 'A' + 1 + (r))
    > +#define PIN_NUMBER(r, c) (((r) - 'A') * 16 + (c) + 200)
    > +#define PIN_A_NUMBER(r, c) PIN_NUMBER(ROW_GROUP_A(r), c)

    You add these #defines but do not use them.

    Yours,
    Linus Walleij


    \
     
     \ /
      Last update: 2013-09-17 15:01    [W:4.799 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site