Messages in this thread | | | Date | Mon, 16 Sep 2013 15:52:31 -0400 | From | KOSAKI Motohiro <> | Subject | Re: [RESEND PATCH v5 1/4] mm/vmalloc: don't set area->caller twice |
| |
On 9/14/2013 7:45 PM, Wanpeng Li wrote: > Changelog: > *v1 -> v2: rebase against mmotm tree > > The caller address has already been set in set_vmalloc_vm(), there's no need
setup_vmalloc_vm()
> to set it again in __vmalloc_area_node. > > Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> > Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> > --- > mm/vmalloc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 1074543..d78d117 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > pages = kmalloc_node(array_size, nested_gfp, node); > } > area->pages = pages; > - area->caller = caller; > if (!area->pages) { > remove_vm_area(area->addr); > kfree(area);
Then, __vmalloc_area_node() no longer need "caller" argument. It can use area->caller instead.
| |