Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 16 Sep 2013 12:51:57 +0300 | From | Tomi Valkeinen <> | Subject | Re: [PATCH 3/3] video: xilinxfb: Simplify error path |
| |
On 12/09/13 08:54, Michal Simek wrote:
> @@ -394,16 +382,12 @@ static int xilinxfb_release(struct device *dev) > /* Turn off the display */ > xilinx_fb_out32(drvdata, REG_CTRL, 0); > > - /* Release the resources, as allocated based on interface */ > - if (drvdata->flags & BUS_ACCESS_FLAG) > - devm_iounmap(dev, drvdata->regs); > #ifdef CONFIG_PPC_DCR > - else > + /* Release the resources, as allocated based on interface */ > + if (!(drvdata->flags & BUS_ACCESS_FLAG)) > dcr_unmap(drvdata->dcr_host, drvdata->dcr_len); > #endif
I might be mistaken, and it's not strictly part of this series, but shouldn't dcr_unmap be called somewhere else also, if the probe fails?
Tomi
[unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |