Messages in this thread | | | Date | Sun, 15 Sep 2013 19:50:00 +0200 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH 2/2] iio: ti_am335x_adc: Take touchscreen channels into account for conversion timeout |
| |
Hi Jonathan,
thanks for your comments
El Sun, Sep 15, 2013 at 05:17:30PM +0100 Jonathan Cameron ha dit:
> On 09/10/13 22:02, Matthias Kaehlcke wrote: > > The calculation of the old conversion timeout value was based on the number of > > channels used by this driver. This doesn't take into account that other channels > > can be used by the touchscreen driver. Adjust the timeout value to the maximum > > if the touchscreen driver is enabled > > > > Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net> > Hmm... This is a bit of an uggly solution. Can we do anything neater via some > callbacks in the underlying mfd?
i agree, it isn't a very elegant solution. as it's a max timeout which should never be hit i thought it might be good enough. using a callback in the mfd is feasible, the mfd has information about the number of steps used by the touchscreen driver. i'll send a reworked version soon
thanks
-- Matthias Kaehlcke Embedded Linux Developer Amsterdam
"The only important thing Windows does better than Debian is implementing the win32 platform" .''`. using free software / Debian GNU/Linux | http://debian.org : :' : `. `'` gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
| |