Messages in this thread Patch in this message | | | From | Jingoo Han <> | Subject | [PATCH 3/3] mfd: timberdale: remove unnecessary pci_set_drvdata() | Date | Thu, 12 Sep 2013 15:44:31 +0900 |
| |
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/mfd/timberdale.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c index a6755ec..084767b 100644 --- a/drivers/mfd/timberdale.c +++ b/drivers/mfd/timberdale.c @@ -829,12 +829,10 @@ err_config: err_ioremap: release_mem_region(priv->ctl_mapbase, CHIPCTLSIZE); err_request: - pci_set_drvdata(dev, NULL); err_start: pci_disable_device(dev); err_enable: kfree(priv); - pci_set_drvdata(dev, NULL); return -ENODEV; } @@ -851,7 +849,6 @@ static void timb_remove(struct pci_dev *dev) pci_disable_msix(dev); pci_disable_device(dev); - pci_set_drvdata(dev, NULL); kfree(priv); } -- 1.7.10.4
| |