Messages in this thread | | | Date | Thu, 12 Sep 2013 12:00:48 +0530 | From | "Srivatsa S. Bhat" <> | Subject | Re: [PATCH 3/3] cpufreq: Prevent problems in update_policy_cpu() if last_cpu == new_cpu |
| |
On 09/12/2013 12:01 PM, Viresh Kumar wrote: > On 12 September 2013 11:51, Srivatsa S. Bhat > <srivatsa.bhat@linux.vnet.ibm.com> wrote: >> That said, indeed currently there is no code in cpufreq that invokes the >> function with last == new. So its not like we are masking an existing bug with >> this patch. If you like, perhaps we can change this patch to print a warning >> when it gets input values with last == new? That prevents disasters and also >> warns when some code is buggy. Sounds like a win-win. > > Exactly what I thought while I was midway reading your mail :) > Probably a WARN().. So that we don't miss any other bugs :) >
Looking at the rate at which we are bumping into each others thoughts, I think maybe we should switch from email to IRC ;-) ;-)
Regards, Srivatsa S. Bhat
| |