Messages in this thread | | | From | (Eric W. Biederman) | Date | Wed, 11 Sep 2013 20:39:27 -0700 | Subject | Re: [PATCH 7/7] sysfs: @name comes before @ns |
| |
Tejun Heo <tj@kernel.org> writes:
> Some internal sysfs functions which take explicit namespace argument > are weird in that they place the optional @ns in front of @name which > is contrary to the established convention. This is confusing and > error-prone especially as @ns and @name may be interchanged without > causing compilation warning. > > Swap the positions of @name and @ns in the following internal > functions.
Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
@ns is more significant so it should come first.
Where do we have the backwards convention of putting @name first?
Eric
| |