Messages in this thread | | | Subject | Re: [RFC PATCH] vsnprintf: Remove use of %n and convert existing uses | From | Tetsuo Handa <> | Date | Thu, 12 Sep 2013 08:40:54 +0900 |
| |
Joe Perches wrote: > - seq_printf(m, "%s%d%n", con->name, con->index, &len); > + len = seq_printf(m, "%s%d", con->name, con->index);
Isn't len always 0 or -1 ?
int seq_vprintf(struct seq_file *m, const char *f, va_list args) { int len;
if (m->count < m->size) { len = vsnprintf(m->buf + m->count, m->size - m->count, f, args); if (m->count + len < m->size) { m->count += len; return 0; } } seq_set_overflow(m); return -1; } EXPORT_SYMBOL(seq_vprintf);
int seq_printf(struct seq_file *m, const char *f, ...) { int ret; va_list args;
va_start(args, f); ret = seq_vprintf(m, f, args); va_end(args);
return ret; } EXPORT_SYMBOL(seq_printf);
| |