Messages in this thread | | | Date | Wed, 11 Sep 2013 12:31:18 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: dgnc: fix potential format string flaw |
| |
On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote: > In the former case, format characters will get processed by the > sprintf logic. In the latter, they are printed as-is. In this specific > case, if there was a way to inject strings like "ohai %n" into the > msgbuf string, the former would actually attempt to resolve the %n. In > the simple case, this could lead to Oopses, and in the unlucky case, > it could allow arbitrary memory writing and execution control. > > http://en.wikipedia.org/wiki/Uncontrolled_format_string
The kernel ignores %n so hopefully it can't actually write to memory.
regards, dan carpenter
| |