Messages in this thread | | | Date | Tue, 10 Sep 2013 13:52:24 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v3] gpio: interrupt consistency check for OF GPIO IRQs |
| |
On 09/10/2013 07:56 AM, Javier Martinez Canillas wrote: ... > The only thing that this patch tries to solve is when a driver expect to request > a IRQ and it doesn't care if is a real IRQ line from an interrupt controller or > a GPIO pin mapped as an IRQ.
That can be solved in the interrupt chip driver. The fact the previous attempt didn't work doesn't mean that it's impossible.
> With board files we used to explicitly do the GPIO setup > (gpio_{request,direction_input}) but with DT these board files are gone and we > need a way to setup a GPIO implicitly when is mapped as an IRQ.
Well, that's just an example of hacking around something in a board file that should have been fixed in the GPIO/IRQ controller.
> That's the only use case that this patch covers. ... > Also, it would be great if we can find a temporary solution so we can finally > have ethernet working with DT on most OMAP2+ boards. Since I expect that doing > the mentioned change on gpiolib would take at least a couple of kernel releases.
Really? I thought this patch was error-checking to make sure that different drivers didn't request a GPIO and an IRQ that are actually the same signal. This patch shouldn't affect any functionality except in cases where there's a bug in the DT (incorrect GPIO/IRQ passed to some driver).
| |