Messages in this thread | | | Date | Tue, 10 Sep 2013 17:35:00 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 0/7] preempt_count rework -v2 |
| |
On Tue, Sep 10, 2013 at 08:29:16AM -0700, Arjan van de Ven wrote:
> also.. yuck on using "dec" "dec" sucks, please use "sub foo ,1" > instead (dec sucks because of its broken flags behavior; it creates > basically a bubble in the pipeline)
Then someone needs to go change:
atomic{,64}_dec*() local{,64}_dec*() percpu_add_op()
All of which use decl/incl, percpu_add_op() actually goes out of its way to generate them.
Also, subl ,1 is 4 bytes larger.
| |