Messages in this thread | | | Date | Tue, 10 Sep 2013 09:45:33 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH] workqueue: remove redundant timer_stats_timer_set_start_info() call |
| |
On Tue, Sep 10, 2013 at 02:35:27PM +0800, Libin wrote: > From: Li Bin <huawei.libin@huawei.com> > > There is a redundant call for timer_stats_timer_set_start_info(), > because it is the responsibility of the 'timer add' function: > > add_timer_on() > |- timer_stats_timer_set_start_info() > > add_timer() > |- mod_timer() > |- __mod_timer() > |- timer_stats_timer_set_start_info() > > So the calling here is redundant, remove it.
I think it's intentional to record the caller's address so that timers from delayed_work items can be distinguished.
Thanks.
-- tejun
| |