Messages in this thread | | | Date | Fri, 9 Aug 2013 12:33:23 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 2/3] perf: Account freq events globally |
| |
On Fri, Aug 02, 2013 at 06:29:55PM +0200, Frederic Weisbecker wrote: > Freq events may not always be affine to a particular CPU. As such, > account_event_cpu() may crash if we account per cpu a freq event > that has event->cpu == -1. > > To solve this, lets account freq events globally. In practice > this doesn't change much the picture because perf tools create > per-task perf events with one event per CPU by default. Profiling a > single CPU is usually a corner case so there is no much point in > optimizing things that way. > > Reported-by: Jiri Olsa <jolsa@redhat.com> > Suggested-by: Peter Zijlstra <peterz@infradead.or> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Jiri Olsa <jolsa@redhat.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > Cc: Stephane Eranian <eranian@google.com>
no more OOPSes ;-)
Tested-by: Jiri Olsa <jolsa@redhat.com
| |