Messages in this thread | | | Date | Fri, 09 Aug 2013 18:15:50 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 03/13] tracing/kprobes: Make stack and memory fetch functions static |
| |
(2013/08/09 16:35), Namhyung Kim wrote: > Hi Masami-san, > > On Mon, 05 Aug 2013 18:04:09 +0900, Masami Hiramatsu wrote: >> (2013/07/31 18:03), Namhyung Kim wrote: >>> From: Namhyung Kim <namhyung.kim@lge.com> >>> >>> Those fetch functions need to be implemented differently for kprobes >>> and uprobes. Since the symbol and deref fetch functions don't call >>> those directly anymore, we can make them static and implement them >>> separately. >> >> Hmm, I think this should be done in 1/13, since this is partially >> reverted it in the same series. If you concern about tweaking other >> one's patch, you can add you singed-off-by to it. :) > > The problem is that it should be marked static after converting to > ->fetch() member. Otherwise the symbol and deref fetch method won't see > memory fetch functions like:
Ah, right. We still use it from deref. :)
Thanks!
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |