lkml.org 
[lkml]   [2013]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors
    On Thu, Aug 08, 2013 at 06:03:49PM +0100, Paul McQuade wrote:
    > -int InterfaceFileDownload( PVOID psIntfAdapter,
    > - struct file *flp,
    > - unsigned int on_chip_loc);
    > +int InterfaceFileDownload(PVOID psIntfAdapter,
    > + struct file *flp,
    > + unsigned int on_chip_loc);


    The very first line in this patch is totally wrong... :(

    This is an automated patch. I'm not going to review any further.
    Automated patches create a problem for reviews because they are
    far harder to review than they are to generate. I'm not sure what
    the solution is...

    Anyway, the patch is very wrong.

    regards,
    dan carpenter


    \
     
     \ /
      Last update: 2013-08-08 23:01    [W:2.333 / U:1.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site