lkml.org 
[lkml]   [2013]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] extable: Skip sorting if the table is empty
Hello,

[adding akpm to Cc:]

On Wed, Jul 17, 2013 at 09:55:11AM +0200, Uwe Kleine-König wrote:
> At least on ARM no-MMU the extable is empty and so there is nothing to
> sort. So add a check for the table to be empty which effectively only
> changes that the misleading pr_notice is suppressed.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> I first tried to select BUILDTIME_EXTABLE_SORT for ARM no-MMU, too, but that
> failed to build with
>
> no __ex_table in file: vmlinux
>
> . I didn't dig deeper for the reasons, but maybe this is worth fixing, too?
this doesn't appear in current next and I didn't get any feed back yet.

What do you think?

Thanks
Uwe

> kernel/extable.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/extable.c b/kernel/extable.c
> index 67460b9..832cb28 100644
> --- a/kernel/extable.c
> +++ b/kernel/extable.c
> @@ -41,7 +41,7 @@ u32 __initdata main_extable_sort_needed = 1;
> /* Sort the kernel's built-in exception table */
> void __init sort_main_extable(void)
> {
> - if (main_extable_sort_needed) {
> + if (main_extable_sort_needed && __stop___ex_table > __start___ex_table) {
> pr_notice("Sorting __ex_table...\n");
> sort_extable(__start___ex_table, __stop___ex_table);
> }

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-08-08 13:01    [W:0.062 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site