Messages in this thread | | | Date | Wed, 07 Aug 2013 09:58:53 -0700 | From | John Stultz <> | Subject | Re: [PATCH] clocksource: add an "menu" item to Kconfig |
| |
On 08/07/2013 09:30 AM, Sebastian Andrzej Siewior wrote: > On 08/07/2013 06:21 PM, John Stultz wrote: >> On 08/07/2013 03:56 AM, Sebastian Andrzej Siewior wrote: >>> This patch adds a menu item to clocksource' Kconfig file. Without it the >>> changeable items look somehow lost in the main drivers' menu >> So I'd like to push back on this a bit and ask why we need user-visible >> clocksource config options? > There was one visible Option if I remember correctly. I added two and > was wondering once I found them. I do have a PCI card which provides a > clock source and clock events device. So I assumed select <m|y> would > be doable.
PCI card, eh? (Heh. In writing my previous mail, I think I even wrote "These are clocksources soldered to the motherboard, not pci cards!", but deleted it as it didn't seem useful. :)
So I think that's actually a first for clocksource drivers.
So, if there are genuinely cross-architecture pluggable clocksources, that aren't part of a platform definition, I would be ok with making an exception. But I'd want to make sure that we kept a high-bar for adding clocksource options, so that folks don't just clutter up the Kconfig menu.
That said, Daniel (now cc'ed - sorry for not cc'ing you earlier!) is now in charge of the clocksource directory, so my objections and wishes aren't as important as his.
thanks -john
| |