lkml.org 
[lkml]   [2013]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/7] usb: musb: omap2430: Don't use omap_get_control_dev()
    Hi,

    On Thursday 01 August 2013 07:35 PM, Roger Quadros wrote:
    > omap_get_control_dev() is being deprecated as it doesn't support
    > multiple instances. As control device is present only from OMAP4
    > onwards which supports DT only, we use phandles to get the
    > reference to the control device.
    >
    > Signed-off-by: Roger Quadros <rogerq@ti.com>
    > ---
    > drivers/usb/musb/omap2430.c | 22 ++++++++++++++++++----
    > 1 files changed, 18 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
    > index ebb46ec..1db9588 100644
    > --- a/drivers/usb/musb/omap2430.c
    > +++ b/drivers/usb/musb/omap2430.c
    > @@ -38,6 +38,7 @@
    > #include <linux/delay.h>
    > #include <linux/usb/musb-omap.h>
    > #include <linux/usb/omap_control_usb.h>
    > +#include <linux/of_platform.h>
    >
    > #include "musb_core.h"
    > #include "omap2430.h"
    > @@ -547,12 +548,25 @@ static int omap2430_probe(struct platform_device *pdev)
    > }
    >
    > if (pdata->has_mailbox) {

    I think you can remove this this check all together. Mailbox is present
    only from OMAP4 so it can be dt only.

    Thanks
    Kishon


    \
     
     \ /
      Last update: 2013-08-06 14:21    [W:4.096 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site