Messages in this thread | | | Subject | Re: do_div() silently truncates "base" to 32bit | From | Joe Perches <> | Date | Fri, 30 Aug 2013 16:28:39 -0700 |
| |
On Fri, 2013-08-30 at 15:48 -0700, Randy Dunlap wrote: > On 08/30/13 15:14, Anatol Pomozov wrote: > > But another question still remains: why compiler does not warn that > > size truncation happens? How to prevent bugs like CFQ one in the > > future? Should we add a compile-time assert to do_div() to prevent > > passing 64 numbers in "base" macro parameter? > That sounds like a fine idea to me.
Geert thought so too and submitted a patch
http://www.spinics.net/lists/linux-btrfs/msg26788.html
| |