lkml.org 
[lkml]   [2013]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] pinctrl: sunxi: drop lock on error path
Date
>@@ -291,8 +291,10 @@ static int sunxi_pconf_group_set(struct pinctrl_dev
>*pctldev,
> switch (pinconf_to_config_param(configs[i])) {
> case PIN_CONFIG_DRIVE_STRENGTH:
> strength = pinconf_to_config_argument(configs[i]);
>- if (strength > 40)
>+ if (strength > 40) {
>+ spin_unlock_irqrestore(&pctl->lock, flags);
> return -EINVAL;
>+ }
> /*
> * We convert from mA to what the register expects:
> * 0: 10mA

Looks good.

Regards,
Sherman



\
 
 \ /
  Last update: 2013-08-29 20:22    [W:0.055 / U:3.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site