Messages in this thread | | | Date | Thu, 29 Aug 2013 18:21:59 +0200 | Subject | Re: [PATCH] fuse: fix race in fuse_writepages() | From | Miklos Szeredi <> |
| |
On Thu, Aug 29, 2013 at 2:38 PM, Maxim Patlasov <mpatlasov@parallels.com> wrote:
>> Just one nit, why orig_pages? req->pages is already there, so why >> duplicate it? > > > req->pages is there, but it is already occupied by new pages (allocated by > fuse_writepages_fill). We can't re-use req->pages for original pages because > as soon as we put the request to bg_queue (in fuse_writepages_send) and > released fc->lock, req->pages may be accessed w/o any delay. So we have two > bunches of pointers to "struct page" to be stashed somewhere : original and > new one. req->pages is for new pages, orig_pages[] is for original ones.
Yeah. Applied the original patch.
Thanks, Miklos
| |