Messages in this thread | | | Date | Wed, 28 Aug 2013 12:04:53 +0530 | Subject | Re: [PATCH] cpufreq: Don't use smp_processor_id() in preemptible context | From | Viresh Kumar <> |
| |
On 28 August 2013 03:31, Stephen Boyd <sboyd@codeaurora.org> wrote: > diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c > index b9b20fd..523af48 100644 > --- a/drivers/cpufreq/cpufreq_governor.c > +++ b/drivers/cpufreq/cpufreq_governor.c > @@ -137,7 +137,7 @@ void gov_queue_work(struct dbs_data *dbs_data, struct cpufreq_policy *policy, > return; > > if (!all_cpus) { > - __gov_queue_work(smp_processor_id(), dbs_data, delay); > + __gov_queue_work(policy->cpu, dbs_data, delay);
This is probably wrong.. We wanted to queue work on current cpu and not policy->cpu.. Can you use raw_smp_processor_id()?
> } else { > for_each_cpu(i, policy->cpus) > __gov_queue_work(i, dbs_data, delay); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation >
| |